Skip to content

Temporary use gcc-rs from git until new version released #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 16, 2016

Conversation

Phaiax
Copy link
Contributor

@Phaiax Phaiax commented Oct 15, 2016

No description provided.

@japaric
Copy link
Member

japaric commented Oct 15, 2016

@Phaiax Could you tell us more about the motivation of this change?

cc @alexcrichton I'm not sure if this would work well with the plan to integrate this into rust-lang/rust. In fact, I've seen integration errors before because this crate uses gcc 0.3.35 and the crates in rust-lang/rust use an older version.

@Phaiax
Copy link
Contributor Author

Phaiax commented Oct 15, 2016

The readme recommends

[dependencies.compiler_builtins]
git = "https://github.com/rust-lang-nursery/compiler-builtins"
features = ["c"]

But this does not work seamlessly for user projects without some recent changes to gcc.

Edit: Does cargo unify crate versions of build-dependencies?

@japaric
Copy link
Member

japaric commented Oct 15, 2016

But this does not work seamlessly for user projects without some recent changes to gcc.

Do you mean that there some targets for which this crate doesn't compile?

I'd prefer to use a newer gcc release. We just have to bug @alexcrichton to release a new one.

Edit: Does cargo unify crate versions of build-dependencies?

It should.

@Phaiax
Copy link
Contributor Author

Phaiax commented Oct 15, 2016

Yes, the build of the libcompiler-rt uses cc instead of arm-none-.....

@japaric
Copy link
Member

japaric commented Oct 15, 2016

You can e.g. set CC_thumbv6m_none_eabi=arm-none-eabi-gcc to override the default compiler (cc). The gcc crate is not guaranteed to always correctly guess the compiler; it just has some heuristics to guess the prefix based on the target triple.

@Phaiax
Copy link
Contributor Author

Phaiax commented Oct 15, 2016

I know. But I think it was not intended this way :D
Best would be to use the override in the .cargo/config file. But that is ignored for compiler_builtins.

[target.thumbv6m-none-eabi]
linker = "arm-none-eabi-gcc"
ar = "arm-none-eabi-ar"

@alexcrichton
Copy link
Member

We just have to bug @alexcrichton to release a new one.

Done!

@japaric
Copy link
Member

japaric commented Oct 16, 2016

Done!
Thank you, @alexcrichton!

@bors r+
@Phaiax note that if we need to downgrade gcc to integrate this into rust-lang/rust, we'll do that.

@bors
Copy link
Contributor

bors commented Oct 16, 2016

📌 Commit 56dc20a has been approved by japaric

@bors
Copy link
Contributor

bors commented Oct 16, 2016

⌛ Testing commit 56dc20a with merge 600ed3b...

bors added a commit that referenced this pull request Oct 16, 2016
Temporary use gcc-rs from git until new version released
@bors
Copy link
Contributor

bors commented Oct 16, 2016

☀️ Test successful - status-appveyor, travis
Approved by: japaric
Pushing 600ed3b to master...

@bors bors merged commit 56dc20a into rust-lang:master Oct 16, 2016
tgross35 pushed a commit to tgross35/compiler-builtins that referenced this pull request Feb 23, 2025
108: coshf tanhf and atan2f r=japaric a=burrbull

closes rust-lang#44
closes rust-lang#52
closes rust-lang#41

Co-authored-by: Andrey Zgarbul <[email protected]>
Co-authored-by: Zgarbul Andrey <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants